Make transaction execution asynchronous

[drahnr]

#1636 with next merged

[drahnr]

Just adapted to the latest rust lints, and gave the tests another run (make test), looks good. The integration with node and client have some other breaking changes, merging next isn't the solution there, so this is still ongoing.

[igamigo]

Before actually merging this, though, I think it would be great to check this branch's compatibility with the client async PR cc @igamigo.

Got the client to build for WASM and native (which might be enough), but can't really test executions until the node points to this branch as well.

[drahnr]

Before actually merging this, though, I think it would be great to check this branch's compatibility with the client async PR cc @igamigo.

Got the client to build for WASM and native (which might be enough), but can't really test executions until the node points to this branch as well.

That's what I am doing right now.

[bobbinth]

Looks good! Thank you! I left a few small comments inline.

I've also pushed a couple of commits into this branch. These commits:

• Bring it up to the latest next.
• Removed source_manager parameters from the note consumption checker. cc @sergerad.
• Removed async_trait dependency - as far as as could tell, isn't used anywhere (and everything compiled and tested fine w/o it).

I think the next steps here are:

• @PhilippGackstatter - could you address the comments from this review?
• @drahnr - could you open a PR in miden-node that works against this branch - I think we have it already, right? (excluding the changes I made in the last couple of commits).
• Once the above is done, we can merge this into next, and then do the same in miden-node with the corresponding PR.
• After that, @igamigo - let's update the client and run all relevant tests.
• After that, @drahnr - could you address the remaining follow ups from #1708.

[drahnr]

The node branch 0xMiden/node#1122 works with this branch.

[bobbinth]

@drahnr @PhilippGackstatter - any idea why lints and on-std build are failing now?

[bobbinth]

@drahnr @PhilippGackstatter - any idea why lints and on-std build are failing now?

Seems like Miden-VM dependencies were not imported using default-features = false. I've fixed this in the latest commit.

@drahnr - I'm assuming this works fine with the node, but could you double check?

[drahnr]

@drahnr @PhilippGackstatter - any idea why lints and on-std build are failing now?

Seems like Miden-VM dependencies were not imported using default-features = false. I've fixed this in the latest commit.

@drahnr - I'm assuming this works fine with the node, but could you double check?

Works