feat: Add FeeParameters to BlockHeader#1652
Merged
PhilippGackstatter merged 17 commits intonextfrom Aug 1, 2025
Merged
Conversation
Contributor
Author
|
Just realized I forgot to validate the native asset ID in the prologue - will add and re-request reviews then. |
bobbinth
approved these changes
Jul 29, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a few small comments inline - but nothing blocking.
mmagician
reviewed
Jul 30, 2025
mmagician
reviewed
Jul 31, 2025
mmagician
approved these changes
Aug 1, 2025
Collaborator
mmagician
left a comment
There was a problem hiding this comment.
Thanks for the express handling of comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
FeeParameterstoBlockHeader.Changes
FeeParametersstruct defining the native asset of the chain (in which fees are accepted) and a single base fee to keep it simple - to be extended in later work.adv_pipein the kernel. Later additions to the fee params will occupy these zero values anyway.These additions to the tx kernel are currently not tested, which is not ideal. However, it's not easily possible to create a custom block header and pass it into a transaction using the existing tools (mock chain, tx context). Most likely it would be good to extend the tx context builder to allow for something like this, but I'll need to think about it a bit more in the larger context of testing. Similar errors like
ERR_PROLOGUE_GLOBAL_INPUTS_PROVIDED_DO_NOT_MATCH_BLOCK_NUMBER_COMMITMENTare also not tested, so maybe we should come up with a strategy for this.closes #1612