Temporarily bump ACCOUNT_UPDATE_MAX_SIZE to 256 KiB#1464
Merged
Conversation
bobbinth
approved these changes
Jun 18, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! Let's also create an issue for bring the limit back down once we have more efficient MAST serialization.
Contributor
Author
Opened an issue here: #1465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
ACCOUNT_UPDATE_MAX_SIZEfrom 32 KiB to 256 KiB to allow for testing of accounts that were compiled using the Rust to Miden assembly compiler.This is a temporary change to allow for testing.
ACCOUNT_UPDATE_MAX_SIZEshould be set back to 32 KiB once MASM produced by the compiler becomes more optimized.Resolves #1441