-
Notifications
You must be signed in to change notification settings - Fork 115
Closed
Labels
good first issueGood for newcomersGood for newcomersstandardsRelated to standard note scripts or account componentsRelated to standard note scripts or account components
Milestone
Description
The ownable::transfer_ownership logic does not check account ID validity, but probably should as a basic sanity check. During the big-endian to little-endian migration, I had suffix and prefix accidentally reversed (which is not a valid account ID), but transfer_ownership accepted the new owner regardless.
This should be as simple as adding this at the beginning of the procedure:
dup.1 dup.1 exec.::miden::protocol::account_id::validate
cc @onurinanc @afa7789 for consideration
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersstandardsRelated to standard note scripts or account componentsRelated to standard note scripts or account components