Skip to content

Add account_id::validate check in ownable::transfer_ownership #2486

@PhilippGackstatter

Description

@PhilippGackstatter

The ownable::transfer_ownership logic does not check account ID validity, but probably should as a basic sanity check. During the big-endian to little-endian migration, I had suffix and prefix accidentally reversed (which is not a valid account ID), but transfer_ownership accepted the new owner regardless.

This should be as simple as adding this at the beginning of the procedure:

dup.1 dup.1 exec.::miden::protocol::account_id::validate

cc @onurinanc @afa7789 for consideration

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersstandardsRelated to standard note scripts or account components

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions