Improve BasicAuthenticator & TransactionAuthenticator for ECDSA Auth Component

[onurinanc]

The secp256k1::verify
function can be used by providing the signature as an advice input.
To obtain the signature as an advice input, we first need the message in the form of a TransactionSummary.
This can be achieved by executing a transaction context where the following call fails as expected:

let tx_summary = match tx_context_init.execute().await.unwrap_err() {
        TransactionExecutorError::Unauthorized(tx_effects) => tx_effects,
        error => panic!("expected abort with tx effects: {error:?}"),
    };

However, when using the BasicAuthenticator, which relies on public key commitments, this execution fails differently.
Instead of returning TransactionExecutorError::Unauthorized(tx_effects), it results in a TransactionProgramExecutionFailed with an ExecutionError, preventing the Box from being returned due to the invalid public key.

such as:
source: InvalidValue("Invalid public key")

Expected Behavior
tx_context_init.execute() should fail with TransactionExecutorError::Unauthorized(tx_effects) so that the resulting TransactionSummary can be obtained as advice input.

[bobbinth]

Would switching to verify_bis function that is being added in 0xMiden/miden-vm#2344 fix this? (patch release of miden-vm with this function should be available soon).

[onurinanc]

Yes, this should fix the issue.

[bobbinth]

I opened #2074 which now used miden-vm v0.19.1 and (hopefully), injects the signatures correctly into the advice provider.

To use this in MASM, you should invoke the verify_ecdsa_k256_keccak procedure.

If you need to prepare the advice data manually, you can use Signature::to_prepared_signature() method.

[onurinanc]

Additionally, I think that tx_summary won't be executed with Unauthorized here since assert.err="ECDSA signature verification failed" executed first, and we will get an error TransactionExecutorError::TransactionProgramExecutionFailed. Am I right?

let tx_summary = match tx_context_init.execute().await.unwrap_err() {
    TransactionExecutorError::Unauthorized(tx_effects) => tx_effects,
    error => panic!("expected abort with tx effects: {error:?}"),
};

[bobbinth]

I believe this has been closed by #2074 and #2083 - but feel free to re-open if not.