-
Notifications
You must be signed in to change notification settings - Fork 115
Description
Feature description
As a follow up of the traces and metrics added to both services, we may want to "merge", at least on the service side, all the information inside the trace and then use some post processing to get metrics. This issue on miden-node has information that is useful.
In the current implementation of the metrics we use a common approach using prometheus which is supported by Pingora out of the box.
Why is this feature needed?
@Mirko-von-Leipzig already gave a good argument regarding this topic:
It also showcases what I dislike about actively doing metrics inline. The metrics code overshadows the actual code logic which > is a bummer (and not this PRs fault).
I'd be interested in trying out an approach where we move all the metrics code into a tracing layer where we inspect the tracing events and update metrics based on those. This would centralize our metrics code into one spot and we only have to instrument the code with tracing. The downside is having to couple something in the traces with the metrics.