feat: add block_num parameter to check_nullifiers_by_prefix#707
Merged
TomasArrachea merged 7 commits intotomasarrachea-stream-sync-statefrom Feb 20, 2025
Merged
Conversation
bobbinth
reviewed
Feb 19, 2025
Mirko-von-Leipzig
approved these changes
Feb 20, 2025
bobbinth
approved these changes
Feb 20, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! One last thing that's I'd probably do is update the description of the endpoint in the README: https://github.com/0xPolygonMiden/miden-node/tree/next/crates/rpc#checknullifiersbyprefix.
TomasArrachea
merged commit eb2de00
into
tomasarrachea-stream-sync-state
2 checks passed
TomasArrachea
deleted the
tomasarrachea-filter-nullifiers-by-blocknum
branch
TomasArrachea
added a commit
that referenced
this pull request
Feb 20, 2025
* feat: add block_num parameter to check_nullifiers_by_prefix * chore: update CHANGELOG * review: add `block_num` parameter as required * review: update CHANGELOG * review: update doc comment * chore: update rpc README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
block_numparameter to theCheckNullifiersByPrefixendpoint. Only nullifiers from blocks equal or bigger thanblock_numwill be included in the response. This change allows using the endpoint to request nullifiers reducing the size of the response.This is part of the changes needed for #685, in order to remove the nullifiers from the SyncState response.
TODO: This requires an additional PR in miden-client to update the endpoint request.