Skip to content

fix(rpc): move CORS layer above AcceptHeaderLayer #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WiktorStarczewski merged 5 commits into from
Feb 25, 2026
+8 −1
Merged

fix(rpc): move CORS layer above AcceptHeaderLayer #1707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
05e170f
fix(rpc): move CORS layer above AcceptHeaderLayer
WiktorStarczewski Feb 24, 2026
3c6a043
chore: add changelog entry for CORS layer fix
WiktorStarczewski Feb 24, 2026
75dc18d
chore: move changelog entry to v0.13.6 (TBD)
WiktorStarczewski Feb 24, 2026
94ac0ba
Update crates/rpc/src/server/mod.rs
WiktorStarczewski Feb 25, 2026
cc42436
Update CHANGELOG.md
WiktorStarczewski Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v0.13.6 (TBD)

- Fixed CORS headers missing from version-rejection responses ([#1707](https://github.com/0xMiden/node/pull/1707)).

## v0.13.5 (2026-02-19)

- OpenTelemetry traces are now flushed before program termination on panic ([#1643](https://github.com/0xMiden/miden-node/pull/1643)).
Expand Down
5 changes: 4 additions & 1 deletion crates/rpc/src/server/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,15 @@ impl Rpc {
.layer(CatchPanicLayer::custom(catch_panic_layer_fn))
.layer(TraceLayer::new_for_grpc().make_span_with(grpc_trace_fn))
.layer(HealthCheckLayer)
// Note: must come before the accept layer, as otherwise accept rejections
// do _not_ get CORS headers applied, masking the accept error in
// web-clients (which would experience CORS rejection).
.layer(cors_for_grpc_web_layer())
.layer(
AcceptHeaderLayer::new(&rpc_version, genesis.commitment())
.with_genesis_enforced_method("SubmitProvenTransaction")
.with_genesis_enforced_method("SubmitProvenBatch"),
)
.layer(cors_for_grpc_web_layer())
// Enables gRPC-web support.
.layer(GrpcWebLayer::new())
.add_service(api_service)
Expand Down
Loading