Merged
Conversation
drahnr
added
the
no changelog
drahnr
changed the title
Mirko-von-Leipzig
approved these changes
Feb 17, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Just glanced through; this also fixes the merge issue from main iiuc
igamigo
approved these changes
Feb 18, 2026
proto/proto/rpc.proto
Outdated
Comment on lines
500
to
501
| // Data needed to update the partial MMR from `request.block_range.block_from + 1` to | ||
| // `pagination_info.block_num`. |
Collaborator
There was a problem hiding this comment.
nit: This still references pagination_info
bobbinth
approved these changes
Feb 18, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! I left a couple of small comments inline.
drahnr
force-pushed
the
bernhard-sync-chain-mmr-again
branch
from
1afb0c8 to
cd1d016
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up to apply the following changes:
SyncChainMMRRPC call