Skip to content

Comments

fix: hash storage map keys#1681

Merged
bobbinth merged 2 commits intomainfrom
igamigo-fix-map-smt
Feb 16, 2026
Merged

fix: hash storage map keys#1681
bobbinth merged 2 commits intomainfrom
igamigo-fix-map-smt

Conversation

@igamigo
Copy link
Collaborator

@igamigo igamigo commented Feb 16, 2026

This PR fixes an issue where the account storage map keys were not being hashed before being inserted in the InnerForest. It was discovered by @Fumuran 's work on a client integration test which should be unblocked once this PR gets merged.

Notable follow ups:

  • Bring this to next
  • Look into adding self-contained integration tests
  • Look into logging network transaction builder errors more (this specifically happens on the DataStore impl for a merkle root not being correct and only an opaque "notes failed to be executed" was being logged). A dev flag could be a good start here.

@igamigo igamigo marked this pull request as ready for review February 16, 2026 19:37
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 0483d0f into main Feb 16, 2026
19 checks passed
@bobbinth bobbinth deleted the igamigo-fix-map-smt branch February 16, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants