Merged
Conversation
Mirko-von-Leipzig
added
no changelog
Mirko-von-Leipzig
force-pushed
the
mirko/ci/msrv
branch
11 times, most recently
from
999dee1 to
74bd5da
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/ci/msrv
branch
from
74bd5da to
70dd50e
Compare
drahnr
approved these changes
Feb 16, 2026
Collaborator
|
Looks good, the linked run is a 404 though. We can replicate this in the client, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
msrvcheck is a nightly run which has been failing recently. Likely due to missingcargo-msrvinstall requirement if I had to guess (error is opaque).This PR simplifies the setup by performing the msrv check directly, with each repo package as a separate item in a github matrix. This means we get the direct msrv error output instead of parsing it via a script.
Example run: https://github.com/0xMiden/miden-node/actions/runs/22032125051