chore: Remove one level of nesting in remote prover client modules#1626
Merged
Mirko-von-Leipzig merged 3 commits intonextfrom Feb 2, 2026
Merged
chore: Remove one level of nesting in remote prover client modules#1626Mirko-von-Leipzig merged 3 commits intonextfrom
Mirko-von-Leipzig merged 3 commits intonextfrom
Conversation
sergerad
added
the
no changelog
bobbinth
reviewed
Feb 2, 2026
| use miden_protocol::block::{BlockHeader, BlockInputs, BlockProof}; | ||
| use miden_remote_prover_client::RemoteProverClientError; | ||
| use miden_remote_prover_client::remote_prover::block_prover::RemoteBlockProver; | ||
| use miden_remote_prover_client::remote_prover::RemoteBlockProver; |
Contributor
There was a problem hiding this comment.
Do we also need the remote_prover namespace? That is, could this be:
use miden_remote_prover_client::RemoteBlockProver;Or is this not a good idea for some reason?
Mirko-von-Leipzig
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per comment.