Skip to content

chore: refactor account delta check test #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mirko-von-Leipzig merged 3 commits into from
Feb 2, 2026
Merged

chore: refactor account delta check test #1621

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
556f088
chore: refactor account delta check test
SantiagoPittella Jan 30, 2026
127279b
Merge branch 'next' into santiagopittella-refactor-delta-check-test
Mirko-von-Leipzig Feb 2, 2026
efb6f3a
Merge branch 'next' into santiagopittella-refactor-delta-check-test
Mirko-von-Leipzig Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 61 additions & 79 deletions crates/rpc/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ use miden_node_utils::limiter::{
use miden_protocol::Word;
use miden_protocol::account::delta::AccountUpdateDetails;
use miden_protocol::account::{
Account,
AccountBuilder,
AccountDelta,
AccountId,
Expand All @@ -28,7 +29,7 @@ use miden_protocol::account::{
};
use miden_protocol::crypto::dsa::ecdsa_k256_keccak::SecretKey;
use miden_protocol::testing::noop_auth_component::NoopAuthComponent;
use miden_protocol::transaction::ProvenTransactionBuilder;
use miden_protocol::transaction::{ProvenTransaction, ProvenTransactionBuilder};
use miden_protocol::utils::Serializable;
use miden_protocol::vm::ExecutionProof;
use miden_standards::account::wallets::BasicWallet;
Expand All @@ -40,6 +41,53 @@ use url::Url;

use crate::Rpc;

/// Byte offset of the account delta commitment in serialized `ProvenTransaction`.
/// Layout: `AccountId` (15) + `initial_commitment` (32) + `final_commitment` (32) = 79
const DELTA_COMMITMENT_BYTE_OFFSET: usize = 15 + 32 + 32;

/// Creates a minimal account and its delta for testing proven transaction building.
fn build_test_account(seed: [u8; 32]) -> (Account, AccountDelta) {
let account = AccountBuilder::new(seed)
.account_type(AccountType::RegularAccountImmutableCode)
.storage_mode(AccountStorageMode::Public)
.with_assets(vec![])
.with_component(BasicWallet)
.with_auth_component(NoopAuthComponent)
.build_existing()
.unwrap();

let delta: AccountDelta = account.clone().try_into().unwrap();
(account, delta)
}

/// Creates a minimal proven transaction for testing.
///
/// This uses `ExecutionProof::new_dummy()` and is intended for tests that
/// need to test validation logic.
fn build_test_proven_tx(account: &Account, delta: &AccountDelta) -> ProvenTransaction {
let account_id = AccountId::dummy(
[0; 15],
AccountIdVersion::Version0,
AccountType::RegularAccountImmutableCode,
AccountStorageMode::Public,
);

ProvenTransactionBuilder::new(
account_id,
[8; 32].try_into().unwrap(),
account.commitment(),
delta.to_commitment(),
0.into(),
Word::default(),
test_fee(),
u32::MAX.into(),
ExecutionProof::new_dummy(),
)
.account_update_details(AccountUpdateDetails::Delta(delta.clone()))
.build()
.unwrap()
}

#[tokio::test]
async fn rpc_server_accepts_requests_without_accept_header() {
// Start the RPC.
Expand Down Expand Up @@ -209,54 +257,19 @@ async fn rpc_server_rejects_proven_transactions_with_invalid_commitment() {
.without_otel_context_injection()
.connect_lazy::<miden_node_proto::clients::RpcClient>();

let account_id = AccountId::dummy(
[0; 15],
AccountIdVersion::Version0,
AccountType::RegularAccountImmutableCode,
AccountStorageMode::Public,
);
// Build a valid proven transaction
let (account, account_delta) = build_test_account([0; 32]);
let tx = build_test_proven_tx(&account, &account_delta);

let account = AccountBuilder::new([0; 32])
.account_type(AccountType::RegularAccountImmutableCode)
.storage_mode(AccountStorageMode::Public)
.with_assets(vec![])
.with_component(BasicWallet)
.with_auth_component(NoopAuthComponent)
.build_existing()
.unwrap();

let other_account = AccountBuilder::new([1; 32])
.account_type(AccountType::RegularAccountUpdatableCode)
.storage_mode(AccountStorageMode::Private)
.with_assets(vec![])
.with_component(BasicWallet)
.with_auth_component(NoopAuthComponent)
.build_existing()
.unwrap();
let incorrect_commitment_delta: AccountDelta = other_account.try_into().unwrap();
let incorrect_commitment_delta_bytes = incorrect_commitment_delta.to_commitment().as_bytes();

let account_delta: AccountDelta = account.clone().try_into().unwrap();

// Send any request to the RPC.
let tx = ProvenTransactionBuilder::new(
account_id,
[8; 32].try_into().unwrap(),
account.commitment(),
account_delta.clone().to_commitment(), // delta commitment
0.into(),
Word::default(),
test_fee(),
u32::MAX.into(),
ExecutionProof::new_dummy(),
)
.account_update_details(AccountUpdateDetails::Delta(account_delta))
.build()
.unwrap();
// Create an incorrect delta commitment from a different account
let (other_account, _) = build_test_account([1; 32]);
let incorrect_delta: AccountDelta = other_account.try_into().unwrap();
let incorrect_commitment_bytes = incorrect_delta.to_commitment().as_bytes();

// Corrupt the transaction bytes with the incorrect delta commitment
let mut tx_bytes = tx.to_bytes();
let offset = 15 + 32 + 32;
tx_bytes[offset..offset + 32].copy_from_slice(&incorrect_commitment_delta_bytes);
tx_bytes[DELTA_COMMITMENT_BYTE_OFFSET..DELTA_COMMITMENT_BYTE_OFFSET + 32]
.copy_from_slice(&incorrect_commitment_bytes);

let request = proto::transaction::ProvenTransaction {
transaction: tx_bytes,
Expand Down Expand Up @@ -295,39 +308,8 @@ async fn rpc_server_rejects_tx_submissions_without_genesis() {
.without_otel_context_injection()
.connect_lazy::<miden_node_proto::clients::RpcClient>();

let account_id = AccountId::dummy(
[0; 15],
AccountIdVersion::Version0,
AccountType::RegularAccountImmutableCode,
AccountStorageMode::Public,
);

let account = AccountBuilder::new([0; 32])
.account_type(AccountType::RegularAccountImmutableCode)
.storage_mode(AccountStorageMode::Public)
.with_assets(vec![])
.with_component(BasicWallet)
.with_auth_component(NoopAuthComponent)
.build_existing()
.unwrap();

let account_delta: AccountDelta = account.clone().try_into().unwrap();

// Send any request to the RPC.
let tx = ProvenTransactionBuilder::new(
account_id,
[8; 32].try_into().unwrap(),
account.commitment(),
account_delta.clone().to_commitment(), // delta commitment
0.into(),
Word::default(),
test_fee(),
u32::MAX.into(),
ExecutionProof::new_dummy(),
)
.account_update_details(AccountUpdateDetails::Delta(account_delta))
.build()
.unwrap();
let (account, account_delta) = build_test_account([0; 32]);
let tx = build_test_proven_tx(&account, &account_delta);

let request = proto::transaction::ProvenTransaction {
transaction: tx.to_bytes(),
Expand Down