Merged
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-enum-note-type
branch
from
e077af2 to
97d46f5
Compare
bobbinth
reviewed
Jan 27, 2026
Mirko-von-Leipzig
requested changes
Jan 27, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Just the integer cast change to enum matching pls
SantiagoPittella
force-pushed
the
santiagopittella-enum-note-type
branch
from
97d46f5 to
3fbd4b3
Compare
| .try_into()?; | ||
| let note_type = NoteType::try_from(u64::from(value.note_type))?; | ||
| let note_type = proto::note::NoteType::try_from(value.note_type) | ||
| .map_err(|_| ConversionError::EnumDiscriminantOutOfRange)? |
Collaborator
There was a problem hiding this comment.
Is this required? Seems like its mapping from E -> E?
Collaborator
Author
There was a problem hiding this comment.
This try_from is implemented by prost, is the casting from the i32 to an Enum variant and returns a custom error
Collaborator
There was a problem hiding this comment.
Man that's so weird. What's even the point of the enum if they never actually use it in the code..
Mirko-von-Leipzig
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #624