feat: add termination on root mismatch in store#1569
Merged
Conversation
Mirko-von-Leipzig
approved these changes
Jan 22, 2026
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Only question for me is whether this is the correct sync primitive, but its probably just semantics tbh. e.g. https://docs.rs/tokio/latest/tokio/sync/struct.Notify.html.
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Contributor
Author
|
I considered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the store finds itself in a situation where the nullifier tree update doesn't align with the nullifier root in the block_header
Review notes:
mpscso we don't have toOptionwrap, we can have multiple concurrent requests that trigger the code-path, having channel capacity small means the first to hit the path will block all following ones and trigger terminationState::loadis not called via RPC, so the error does terminate correctlyCloses #1328