fix(ntx): mempool subscription has a race condition#1568
Merged
Mirko-von-Leipzig merged 1 commit intonextfrom Jan 22, 2026
Merged
fix(ntx): mempool subscription has a race condition#1568Mirko-von-Leipzig merged 1 commit intonextfrom
Mirko-von-Leipzig merged 1 commit intonextfrom
Conversation
Mirko-von-Leipzig
added
the
no changelog
Mirko-von-Leipzig
force-pushed
the
mirko/hack-subscription
branch
2 times, most recently
from
5450e4a to
b870456
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/hack-subscription
branch
from
b870456 to
c7654fd
Compare
SantiagoPittella
approved these changes
Jan 22, 2026
igamigo
approved these changes
Jan 22, 2026
Collaborator
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! I agree that option 2 is better in the longer term, and also probably simplifies things a bit more.
Collaborator
|
Do we want to include the option 2 in the 0.13 release? I can start to work on it and maybe be ready for a patch release or something |
Collaborator
Author
Sure that would be welcome. I did start with (2) but then realized ideally we should distinguish between initializing (subscribe and sync with the store) and running (main event loop). And that became a larger delta. I'll create an issue and assign you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick but hacky solution for #1566.
aka this is solution (1), but more ideal would be (2). (2) involves more of larger refactor so I'm punting on that for now.
Closes #1566.