feat: Integrate ntx-builder with validator #1453
Merged
Conversation
…x-builder-validator
This was referenced Jan 8, 2026
Collaborator
SantiagoPittella
left a comment
SantiagoPittella
left a comment
There was a problem hiding this comment.
Looking good, besides Mirko's comment
Collaborator
Author
|
@Mirko-von-Leipzig @SantiagoPittella I have undone the changes that remove the block producer submit logic. Should not have been part of this PR. |
Mirko-von-Leipzig
approved these changes
Jan 13, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
The one question (I do think the order must be swapped)
SantiagoPittella
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We want network transactions to go through the same validator flow as all other transactions. Currently the ntx-builder submits proven transactions to the block producer directly which bypasses the validator flow.
Closes #1309.
Changes
ValidatorClientfor ntx-builder.BlockProducerClient::submit_proven_transactionfor ntx-builder.ValidatorClient::submit_proven_transaction.