Merged
Conversation
drahnr
force-pushed
the
bernhard-1353-largesmt-for-nullifier-tree
branch
from
05c08e0 to
9673db7
Compare
drahnr
force-pushed
the
bernhard-1353-largesmt-for-nullifier-tree
branch
from
5a25fab to
601f48b
Compare
sergerad
approved these changes
Nov 29, 2025
bobbinth
reviewed
Nov 30, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments/questions inline.
Mirko-von-Leipzig
approved these changes
Dec 1, 2025
drahnr
force-pushed
the
bernhard-1353-largesmt-for-nullifier-tree
branch
from
ce738fa to
11c4b07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aapts usage of
NullifierTreetoNullifierTree<S: NullifierTreeBackend>as introduced in 0xMiden/protocol#2091This does not add
RocksDBbacking, same reasoning as #1352 - CI overhead/setup and compile time.Issue #1353
Includes changes from #1381 since we have two APIs broken by two separate PRs in
miden-basethat we now have to deal with in one PR to appease CI.