-
Notifications
You must be signed in to change notification settings - Fork 99
Labels
network transactionsRelates to the network transactions featureRelates to the network transactions feature
Milestone
Description
When upgrading miden-node to latest miden-base, there are some relevant changes.
Note::is_network_note,NoteTag::is_single_targetandNoteTag::NetworkAccountwere removed, so there is no more conversion path fromNoteTagtoNetworkAccountPrefix. Instead, notes should be detected as network notes whenever their attachment ismiden_standards::note::NetworkAccountTarget, which can be decoded withtry_from.- It seems it would make sense to redefine
NetworkAccountPrefix(u32)asNetworkAccountId(AccountId)and then convertNetworkAccountTarget::target_idintoNetworkAccountId. - Similarly,
SingleTargetNetworkNotewould conceptually be aNotewhose attachment isNetworkAccountTarget.
- It seems it would make sense to redefine
NoteMetadata::auxwas removed and can be replaced withNoteAttachment, but most likely aux was just set to zero anyway in most places.NoteMetadata::execution_hintwas moved toNetworkAccountTarget.
I don't see any usages of note tag or metadata in the network monitor that aren't covered by the above, but ping me for questions.
One thing I noticed while looking at usages in node was that we should change impl TryFrom<NoteAttachment> for NetworkAccountTarget to &NoteAttachment. Changed in 0xMiden/protocol#2289.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
network transactionsRelates to the network transactions featureRelates to the network transactions feature