fix: mismatched Push expectations in decoder syscall_block test #2207
Conversation
There was a problem hiding this comment.
The original test was passing because the test framework checks the operation, but not which values were pushed. Would you consider enhancing the test framework to validate the actual pushed values?
You could grab the immediate values in the hasher_tracecolumns, and create a check_op_decoding_with_imm which would check values, as well as the operation, and update tests to use it.
corrected |
processor/src/decoder/tests.rs
Outdated
| // | ||
| // begin | ||
| // fmp <- fmp + 1 | ||
| // syscall.bar |
There was a problem hiding this comment.
I think there is a typo here: this should probably be call.bar - right?
Describe your changes
The syscall_block test expected Push(TWO) in the program’s first SPAN and Push(ONE) in bar’s SPAN, while the constructed MAST nodes use Push(ONE) for the initial +1 FMP update and Push(TWO) for bar’s +2 FMP update. This mismatch caused the test to assert against values that cannot occur given the program structure and FmpUpdate semantics. The change aligns the expected op decoding with the actual program and documented FMP behavior (CALL resets to FMP_MIN, SYSCALL resets to SYSCALL_FMP_MIN, and FmpUpdate adds the pushed value).