Skip to content

Conversation

Qyriad
Copy link
Contributor

@Qyriad Qyriad commented Sep 23, 2025

Describe your changes

Execution errors in miden-vm analyze's iteration no longer prevent the analysis up to that point from being printed. Instead, the error is recorded as part of the execution details, and reported to the user after printing the analysis.

This especially makes counting cycles much more convenient, as you no longer need to manually discard instructions spent on truncating the stack.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Commits are signed.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.
  • Updated `CHANGELOG.md'

@Qyriad Qyriad force-pushed the qyriad/analyze-until-error branch 2 times, most recently from 29e77aa to a791586 Compare September 23, 2025 13:14
This especially makes counting cycles much more convenient, as you no
longer need to manually discard instructions spent on truncating the
stack.
@Qyriad Qyriad force-pushed the qyriad/analyze-until-error branch from a791586 to a255a5b Compare September 23, 2025 13:16
@Qyriad
Copy link
Contributor Author

Qyriad commented Sep 23, 2025

CI issues have been fixed!

@plafer
Copy link
Contributor

plafer commented Oct 1, 2025

@Qyriad sorry we didn't merge this earlier, but there are now merge conflits. Could you resolve those so we can merge?

@adr1anh
Copy link
Contributor

adr1anh commented Oct 1, 2025

Side note which could be a follow-up PR. I'm not familiar with analyze so this point may be moot.

Does analyze still print out all the output from debug.* commands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants