feat: adding a simple benchmarking CLI for the examples#33
Merged
Dominik1999 merged 1 commit intomainfrom Dec 20, 2022
Merged
Conversation
Dominik1999
force-pushed
the
add_benchmarking_cli
branch
2 times, most recently
from
8e390d1 to
14d9d40
Compare
Dominik1999
force-pushed
the
add_benchmarking_cli
branch
3 times, most recently
from
eb311e1 to
5cf1e09
Compare
Dominik1999
force-pushed
the
add_benchmarking_cli
branch
2 times, most recently
from
fad03aa to
09d96ec
Compare
Dominik1999
force-pushed
the
add_benchmarking_cli
branch
from
09d96ec to
3233d4b
Compare
|
@Dominik1999 Issuing |
Dominik1999
force-pushed
the
add_benchmarking_cli
branch
from
3233d4b to
63e8948
Compare
grjte
suggested changes
Dec 20, 2022
Contributor
grjte
left a comment
grjte
left a comment
There was a problem hiding this comment.
Looks great, thank you! There are just a couple small things I'd prefer to adjust before merging.
Dominik1999
force-pushed
the
add_benchmarking_cli
branch
from
63e8948 to
d752ded
Compare
Dominik1999
force-pushed
the
add_benchmarking_cli
branch
from
d752ded to
dc547dd
Compare
grjte
approved these changes
Dec 20, 2022
Contributor
grjte
left a comment
grjte
left a comment
There was a problem hiding this comment.
Looks good, thanks @Dominik1999! I left one comment inline - maybe you can make an issue to address this in the future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9