Conversation
bobbinth
reviewed
Feb 23, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Thank you! Looks good. I added a couple of comments inline.
Also, should we add from_der() method to other signatures (e.g., EdDSA)? Probably not for this PR, but may be good to create an issue for this.
huitseeker
reviewed
Feb 23, 2026
Al-Kindi-0
approved these changes
Feb 23, 2026
Collaborator
Al-Kindi-0
left a comment
Al-Kindi-0
left a comment
There was a problem hiding this comment.
Left a couple of non-blocking comments, otherwise looks good
Contributor
Author
|
bobbinth
approved these changes
Feb 23, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just one comment inline.
sergerad
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Signature::from_der()to support decoding ASN.1 DER encoded ECDSA signatures.