Advice map loading in Miden SDK

[greenhat]

Close #626

This PR is stacked on the #555 and should be merged after it

This PR adds the following functions to the Miden SDK:

/// Pushes a list of field elements onto the advice stack. The list is looked up in the advice map using `key` as the key.
/// Returns the number of elements pushed on the advice stack.
fn adv_push_mapvaln(key: Word) -> Felt;
/// Pops an arbitrary number of words from the advice stack and asserts it matches the commitment.
fn adv_load_preimage(num_words: Felt, commitment: Word) -> Vec<Felt>;

[bitwalker]

Looks good! Just a couple of small things I'd like to change before merging.

[bitwalker]

Maybe we should call this advice.masm instead? I don't think I'd know to look for these intrinsics in a module named io.masm

[greenhat]

Yes. Advice ops are in IO ops section of the book, but IO might be far too generic for the intrinsic file name.

[greenhat]

Done in d236627

[bitwalker]

I don't think it's a good idea to hide the namespacing and re-export everything from t he top level like this - I'd rather try to match the structure of the Miden standard library. Even if we do our own organization, I still think it aids discovery when things are namespaced.

For example, miden_stdlib_sys::merge (which I saw in the diff somewhere here) does not tell you what that function is at all, while miden_stdlib_sys::crypto::merge at least hints that it is a crypto-related operation.

[greenhat]

Good point. What about the types? I suppose we export types from the root, or do we want to export them from specific crates as well?

[greenhat]

Done in d236627

[greenhat]

Thank you! I addressed your notes. Please do another round.

[bitwalker]

Looks good!