Skip to content

Conversation

@0xMax42
Copy link
Owner

@0xMax42 0xMax42 commented Nov 30, 2023

This commit addresses the issue where headings without an explicit ID resulted in ambiguous IDs for repeated headings (e.g., multiple "Summary" headings).

Changes made:

  • PHP:
    • When a heading lacks an ID, a unique identifier is now generated by appending the heading's index to its content-derived ID. This ensures each heading ID is distinct, even when the heading text is repeated across the document.

…of the heading. In the case of repeated headings (e.g. “Summary”), this leads to an ambiguous ID.

The problem is solved by adding the index of all headings to the ID generated in this case.

Changes to
- PHP:
   If the ID does not exist, the given index is appended to the generated ID.
@0xMax42 0xMax42 merged commit b3577dd into main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants