Created & Updated README.md and added simple progress messages#2
Open
samrdev wants to merge 3 commits into0xLeon:masterfrom
Open
Created & Updated README.md and added simple progress messages#2samrdev wants to merge 3 commits into0xLeon:masterfrom
samrdev wants to merge 3 commits into0xLeon:masterfrom
Conversation
Owner
|
No Problem. You could have actually just reuse the existing Pull Request. When you push commit to the same branch you used as base for the Pull Request, the new commit will also be added to the Pull Requests. That's why you usually use a separate branch for each feature you want to send a pull request for. If poissible, plase separate these two features in this pull request and use one for each feature (Readme / Progress). That simplifies tracking some missing points for each feature separatly. I'll add some hints to the commits themselves in a few minuts, because there are some minor stylegoid related issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, that is my first pull requesting after forking in Github and I'm still finding out how this works. Thank you for appreciating my work and time to create the README.md. I hope you will merge my little progress additions, too. Thanks!