Add x86 build support for Detours #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice thanks for the fix. My CLion tool chain forced it to be x86 I guess and it slipped through xD |
0xKate
added a commit
that referenced
this pull request
Sep 13, 2025
- Fix Detours architecture handling (#1) - Enforce naming conventions across projects. - Rename Shared.h → LogUtils.h (reduce ambiguity). - Add OriginalBytes copy inside Detour wrapper. - General ByteWeaver cleanup.⚠️ Breaking: child projects will be incompatible due to naming enforcement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be off the mark, but when trying to add ByteWeaver to an x86 project it was failing due to Detours building for x64 then searching in the x86 dir for the x86 lib. Manually building it for my project passing the architecture in through DETOURS_TARGET_PROCESSOR fixed it 😊