fix(tests): properly silence log output #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `init` allows it to also work for benchmarks. And `log.Silence` was sometimes getting overridden by `log.init`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
- Coverage 93.77% 93.76% -0.01%
==========================================
Files 72 72
Lines 5892 5890 -2
==========================================
- Hits 5525 5523 -2
Misses 284 284
Partials 83 83 ☔ View full report in Codecov by Sentry. |
ThinkChaos
force-pushed
the
fix/tests-log-silence
branch
from
17e3c51
to
b871eb5
Compare
kwitsch
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
initallows it to also work for benchmarks.And
log.Silencewas sometimes getting overridden bylog.init.