feat: add `SlashingWithdrawalRouter` #5

0xClandestine · 2025-05-14T22:07:11Z

Motivation:

We want to hold slashed funds in escrow temporarily to maintain protocol security (prevent malicious actors from draining the contracts).

Modifications:

Add SlashingWithdrawalRouter.

Result:

The SlashingWithdrawalRouter contract is added for managing slashed funds in the EigenLayer protocol. It provides a mechanism to handle the burning or redistribution of slashed shares after a delay period, ensuring proper handling of slashed funds while maintaining protocol security.

non-fungible-nelson

Some comments and clarifications -- looks good for a first cut. Thanks!

src/contracts/core/SlashingWithdrawalRouter.sol

non-fungible-nelson · 2025-05-16T16:44:31Z

src/contracts/core/SlashingWithdrawalRouter.sol

+        // Assert that the redistribution is not paused.
+        require(!escrow.paused, RedistributionCurrentlyPaused());
+
+        // QUESTION: How do we want to check maturity? Are we storing it during initiation or parsing JIT?


@ypatil12 @0xClandestine I think its OK to just store during initiation some future a block number. We are anticipating a programmatic call here from the ALM right? if so, we can just parse against the maturity block number >= some number of days in blocks (4)

We want to store the block that it was queued and then read the delay. We should have a function where the delay can be set by the ops multisig

This delay applies to a list of strategies passed in. The delay can be set on a per strategy basis, if not set use the global

src/contracts/core/SlashingWithdrawalRouter.sol

non-fungible-nelson · 2025-05-16T16:58:27Z

Another note we need to discern on immutability:

do we allow the admin role to update the pauser at will?
rescuing the contract should only be done through an upgrade through governance (community multi-sig)

src/contracts/interfaces/ISlashingWithdrawalRouter.sol

src/contracts/core/SlashingWithdrawalRouter.sol

ypatil12 · 2025-05-16T18:30:31Z

src/contracts/core/SlashingWithdrawalRouter.sol

+        // Assert that the redistribution is not paused.
+        require(!escrow.paused, RedistributionCurrentlyPaused());
+
+        // QUESTION: How do we want to check maturity? Are we storing it during initiation or parsing JIT?


We want to store the block that it was queued and then read the delay. We should have a function where the delay can be set by the ops multisig

ypatil12 · 2025-05-16T18:30:49Z

src/contracts/core/SlashingWithdrawalRouter.sol

+        // Assert that the redistribution is not paused.
+        require(!escrow.paused, RedistributionCurrentlyPaused());
+
+        // QUESTION: How do we want to check maturity? Are we storing it during initiation or parsing JIT?


This delay applies to a list of strategies passed in. The delay can be set on a per strategy basis, if not set use the global

ypatil12

Can we add introspection on:

List of redistributions for an opSet/slashID
Whether the redistribution is completable

src/contracts/core/SlashingWithdrawalRouter.sol

ypatil12

We also need a way for us to introspect storage to get the slashes that need to be burnt (send to 0xEigen)

src/contracts/core/DelegationManager.sol

src/contracts/core/SlashingWithdrawalRouterStorage.sol

0xClandestine · 2025-05-19T18:46:54Z

src/contracts/core/SlashingWithdrawalRouterStorage.sol

+    mapping(bytes32 operatorSetKey => mapping(uint256 slashId => RedistributionEscrow escrow)) internal _escrow;
+
+    /// @notice Returns the paused status for a given operator set and slash ID.
+    mapping(bytes32 operatorSetKey => mapping(uint256 slashId => bool paused)) internal _paused;


Feel like this could be improved, thinking we pass in a range of slashIds as upper and lower bounds, can pass type(uint).max in to pause an entire operator set.

src/contracts/permissions/Pausable.sol

src/contracts/core/AllocationManager.sol

src/contracts/core/DelegationManager.sol

src/contracts/core/StrategyManager.sol

src/contracts/core/SlashingWithdrawalRouter.sol

ypatil12

One pass, will review again once we have escrow logic

ypatil12 · 2025-05-20T16:27:23Z

src/contracts/core/StrategyManager.sol

-        // EnumerableMap.set(burnableShares, address(strategy), currentShares + addedSharesToBurn);
-        emit BurnableSharesIncreased(operatorSet, slashId, strategy, addedSharesToBurn);
+        emit BurnableSharesIncreased(operatorSet, slashId, strategy, sharesToBurn);
+


One thing I noticed is that we have 1 call from ALM to DM if multiple strategies are burned, but n calls from DM to SM. Just pointing out - I do think the pattern is fine

Yeah originally we had n calls from ALM to DM too, originally planned to optimize both to reduce external calls with but later found out it's not possible for the DM to SM call. Should reduce the complexity of logs a bit, and make them more readable.

src/contracts/core/StrategyManager.sol

src/contracts/core/SlashingWithdrawalRouter.sol

ypatil12

Style comments

src/contracts/core/SlashingWithdrawalRouter.sol

src/contracts/core/SlashingWithdrawalRouterStorage.sol

src/contracts/core/SlashingWithdrawalRouter.sol

src/contracts/core/SlashingWithdrawalRouterStorage.sol

ypatil12 · 2025-05-20T21:30:07Z

LGTM

* wip * wip * feat: add `SlashingWithdrawalRouter` * perf: optimize `Pausable` for codesize * chore: renaming * refactor: use `Pauseable` instead of OZ `AccessControl` * perf: reduce `Pauseble` codesize * refactor: arrayified inputs * wip * refactor: make struct params arrays * fix: remove unused import * refactor: `redistributionRecipient` == `releaser` * refactor: cleanup * wip * wip * refactor: cleanup * refactor: remove uneeded code * refactor: remove unused error * wip * refactor: review changes * feat: add `getPendingSlashIdsForOperatorSet` * test: wip * test: wip * test: wip * doc: todos * test: wip * refactor: iterate in reverse order to avoid skipping elements * test: passing * feat: add `getPendingBurnOrRedistributions` nested alias * chore: renaming * fix: update gap * fix: dm mock * feat: full introspection * fix: `pendingOperatorSets` removal * fix: update visibility * feat: add delay logic * fix: enforce minimum delay * refactor: review changes * refactor: remove `_checkBurnOrRedistributionDelay` * fix: gap * nit: natspec style * refactor: update headers * refactor: review changes

0xClandestine added 3 commits May 14, 2025 18:06

wip

4b80b68

wip

cc2bd7d

feat: add SlashingWithdrawalRouter

5b96c44

0xClandestine changed the title ~~feat(draft): immutable redistribution escrow~~ feat(draft): add SlashingWithdrawalRouter May 16, 2025

non-fungible-nelson reviewed May 16, 2025

View reviewed changes

ypatil12 reviewed May 16, 2025

View reviewed changes

0xClandestine added 5 commits May 16, 2025 15:25

perf: optimize Pausable for codesize

8c3270c

chore: renaming

13c831f

refactor: use Pauseable instead of OZ AccessControl

427c817

perf: reduce Pauseble codesize

5ac97cb

refactor: arrayified inputs

202e83c

ypatil12 reviewed May 19, 2025

View reviewed changes

src/contracts/core/SlashingWithdrawalRouter.sol Outdated Show resolved Hide resolved

ypatil12 reviewed May 19, 2025

View reviewed changes

src/contracts/core/SlashingWithdrawalRouter.sol Outdated Show resolved Hide resolved

ypatil12 reviewed May 19, 2025

View reviewed changes

0xClandestine added 7 commits May 19, 2025 11:25

wip

f0b2b98

refactor: make struct params arrays

6c81d14

fix: remove unused import

3239323

refactor: redistributionRecipient == releaser

6a05f16

refactor: cleanup

9d72d59

wip

f887fdc

wip

4b90b1a

0xClandestine commented May 19, 2025

View reviewed changes

src/contracts/core/DelegationManager.sol Show resolved Hide resolved

0xClandestine commented May 19, 2025

View reviewed changes

src/contracts/core/SlashingWithdrawalRouterStorage.sol Outdated Show resolved Hide resolved

0xClandestine commented May 19, 2025

View reviewed changes

src/contracts/permissions/Pausable.sol Outdated Show resolved Hide resolved

refactor: cleanup

c183853

ypatil12 reviewed May 19, 2025

View reviewed changes

0xClandestine added 2 commits May 19, 2025 15:29

refactor: remove uneeded code

c329046

refactor: remove unused error

32723b6

0xClandestine added 5 commits May 19, 2025 23:29

test: wip

3d6e531

test: wip

641cd83

test: wip

f63691b

doc: todos

a5578a5

test: wip

fa2dbe1

ypatil12 reviewed May 20, 2025

View reviewed changes

0xClandestine added 11 commits May 20, 2025 12:41

refactor: iterate in reverse order to avoid skipping elements

be61c48

test: passing

70afcc5

feat: add getPendingBurnOrRedistributions nested alias

86c3d72

chore: renaming

b2a16bb

fix: update gap

049bfbf

fix: dm mock

0721fd5

feat: full introspection

342ae96

fix: pendingOperatorSets removal

93a5927

fix: update visibility

ac7b8ee

feat: add delay logic

b2b8599

fix: enforce minimum delay

328c9ec

ypatil12 reviewed May 20, 2025

View reviewed changes

src/contracts/core/SlashingWithdrawalRouter.sol Outdated Show resolved Hide resolved

src/contracts/core/SlashingWithdrawalRouter.sol Outdated Show resolved Hide resolved

src/contracts/core/SlashingWithdrawalRouter.sol Outdated Show resolved Hide resolved

0xClandestine added 4 commits May 20, 2025 16:25

refactor: review changes

2cba7d0

refactor: remove _checkBurnOrRedistributionDelay

ead35f6

fix: gap

ffbf1c0

nit: natspec style

1ff2e26

ypatil12 reviewed May 20, 2025

View reviewed changes

src/contracts/core/SlashingWithdrawalRouterStorage.sol Show resolved Hide resolved

refactor: update headers

e20ec2e

refactor: review changes

7b02b69

0xClandestine changed the title ~~feat(draft): add SlashingWithdrawalRouter~~ feat: add SlashingWithdrawalRouter May 21, 2025

0xClandestine merged commit 60fb3f5 into feat/sm-redistribution-2 May 21, 2025
7 of 12 checks passed

feat: add SlashingWithdrawalRouter #5

feat: add SlashingWithdrawalRouter #5

Uh oh!

Conversation

0xClandestine commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

non-fungible-nelson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

non-fungible-nelson commented May 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ypatil12 commented May 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add `SlashingWithdrawalRouter` #5

feat: add `SlashingWithdrawalRouter` #5

0xClandestine commented May 14, 2025 •

edited

Loading