Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplified error qualifier types #412

Merged
merged 1 commit into from
Feb 8, 2025
Merged

chore: Simplified error qualifier types #412

merged 1 commit into from
Feb 8, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Feb 8, 2025

This pull request focuses on refactoring the error handling in the src/client/http.rs file by consolidating the error types used throughout the code. The changes primarily involve replacing crate::Error with Error to streamline error management.

Key changes include:

Error handling refactor:

  • src/client/http.rs: Updated various use statements to include Error from crate::error and removed redundant imports. [1] [2]
  • src/client/http.rs: Modified the Config struct to use Option<Error> instead of Option<crate::Error>.
  • src/client/http.rs: Updated the execute method in impl Client to return Result<Response, Error> instead of Result<Response, crate::Error>.
  • src/client/http.rs: Changed the Error type in impl tower_service::Service<Request> for Client and impl tower_service::Service<Request> for &'_ Client to Error instead of crate::Error. [1] [2]
  • src/client/http.rs: Refactored error handling in ClientMut, PendingInner, Pending, and PendingRequest to use Error instead of crate::Error. [1] [2] [3] [4] [5]

@0x676e67 0x676e67 merged commit 35b4347 into main Feb 8, 2025
4 checks passed
@0x676e67 0x676e67 deleted the chore branch February 8, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant