Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace unsafe methods with safe methods in ConnectConfiguration #398

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Feb 7, 2025

This pull request includes several updates and refactorings to the Cargo.toml and src/tls files. The main changes involve updating dependencies and refactoring the code to remove unsafe blocks and improve readability.

Dependency Updates:

  • Cargo.toml: Updated the boring2, boring-sys2, and tokio-boring2 dependencies from version 4.15.0 to 4.15.1.

Code Refactoring:

  • src/tls/ext.rs: Added SslOptions to the import statement from boring2::ssl.
  • src/tls/ext.rs: Refactored the enable_ech_grease method to remove the unsafe block and use the set_enable_ech_grease method directly.
  • src/tls/ext.rs: Refactored the add_application_settings method to remove the unsafe block and use the set_alps_use_new_codepoint method directly.
  • src/tls/ext.rs: Refactored the skip_session_ticket method to remove the unsafe block and use the set_options method with SslOptions::NO_TICKET.

Removal of Unused Methods:

  • src/tls/mod.rs: Removed the as_ptr and len methods from the AlpsProtos implementation as they are no longer needed.

@0x676e67 0x676e67 merged commit dda0d42 into main Feb 7, 2025
4 checks passed
@0x676e67 0x676e67 deleted the feat1 branch February 7, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant