Skip to content

Commit

Permalink
Remove stale TODO.
Browse files Browse the repository at this point in the history
We no longer accept all ticket age skews.

Change-Id: Ie4a143cf5762177d9ec8aa5784073b3e63630df3
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/37105
Reviewed-by: Steven Valdez <svaldez@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
  • Loading branch information
davidben authored and CQ bot account: commit-bot@chromium.org committed Aug 16, 2019
1 parent eca48e5 commit 8c98bac
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions ssl/tls13_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -324,10 +324,8 @@ static enum ssl_ticket_aead_result_t select_session(
return ssl_ticket_aead_ignore_ticket;
}

// TODO(davidben,svaldez): Measure this value to decide on tolerance. For
// now, accept all values. https://crbug.com/boringssl/113.
*out_ticket_age_skew =
(int32_t)client_ticket_age - (int32_t)server_ticket_age;
*out_ticket_age_skew = static_cast<int32_t>(client_ticket_age) -
static_cast<int32_t>(server_ticket_age);

// Check the PSK binder.
if (!tls13_verify_psk_binder(hs, session.get(), msg, &binders)) {
Expand Down

0 comments on commit 8c98bac

Please sign in to comment.