Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(field-usage): Crawl chained scopes #356

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Sep 14, 2024

Fixes #353

The AST when we are dealing with nested scopes looks like the following

VariableDeclaration --> CallExpression --> PropertyAccessExpression --> CallExpression --> PropertyAccessExpression

The solution we implement here will keep looking for nested CallExpression and traverse them.

Note that I haven't been able to test this yet and that this is mainly a conceptual solution, I'm intending to test this out before merging 😅

Copy link

changeset-bot bot commented Sep 14, 2024

🦋 Changeset detected

Latest commit: c523388

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@0no-co/graphqlsp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock changed the title fix(field-usage): Crawl nested scopes fix(field-usage): Crawl chained scopes Sep 18, 2024
@JoviDeCroock JoviDeCroock force-pushed the handle-chained-expressions branch 5 times, most recently from 9279662 to b41d28b Compare September 28, 2024 16:25
@JoviDeCroock JoviDeCroock merged commit 563714c into main Sep 28, 2024
1 check passed
@JoviDeCroock JoviDeCroock deleted the handle-chained-expressions branch September 28, 2024 16:30
@github-actions github-actions bot mentioned this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields are flagged as unused after .filter()
1 participant