-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: downloadBlocks wasm error #1371
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
c62ca58
Update sprint 1.12 (#1341)
Hitenjain14 3a57362
fix trailing whitespace (#1343)
Hitenjain14 ad762e4
Merge staging changes (#1346)
peterlimg 9b9fdd7
fix upload select (#1351)
Hitenjain14 f3ec2cc
fix workdir in mobile sdk (#1345)
Hitenjain14 5569b3d
set option to download to disk in wasm (#1348)
Hitenjain14 199dfd0
fix panic in hash chan (#1352)
Hitenjain14 2e55c3f
Fix merge conflict in sprint-1.12 (#1354)
Hitenjain14 4ed3f42
repair in batches (#1347)
Hitenjain14 edf037a
Merge staging (#1365)
Hitenjain14 c002ffc
fix: change downloadBlocks param: alloc -> allocId
ashuvssut e1a614f
Fix stake pool stats (#1356)
Jayashsatolia403 0056303
list pagination (#1368)
Hitenjain14 97b6a5b
Fix sync in windows (#1370)
Roshan-Mehta 09c3757
Add option for mimeType (#1372)
Hitenjain14 9bc91c6
fix shutdown blobber (#1374)
boddumanohar 6f48750
Merge remote-tracking branch 'origin/staging' into sprint-1.12
dabasov e7db14c
Cancel upload (#1332)
Hitenjain14 716e99b
Fix auth response on wasm (#1359)
peterlimg de8ef8c
Download buffer (#1363)
Hitenjain14 3186bd9
Merge branch 'sprint-1.12' into ashu/streaming
ashuvssut 703cbd0
fix req complete cb (#1381)
Hitenjain14 312b5cf
get hardfork round by name (#1385)
Hitenjain14 5cae7a4
made GetFreeAllocationBlobbers public
dabasov 36e5b10
fixed resp format
dabasov ccda3cd
fixed resp format
dabasov 004db9d
[wasm] Expose minersc - stakePool/unstakePool collect rewards (#1386)
peterlimg 293689e
Merge branch 'staging' into sprint-1.12
dabasov cab600c
Merge branch 'sprint-1.12' into ashu/streaming
dabasov e315634
Merge branch 'staging' into ashu/streaming
dabasov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to re-request the allocation if we have an object already`?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wasm logged out
downloadBlocks binder not implemented
becausedownloadBlocks
wasm function did’t work when it took*sdk.Allocation
as parameterso I passed the
allocId
string instead of*sdk.Allocation
as parameterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot pass native go objects from js, so we need to pass allocationID, we have a LRU for allocations so no call will be made to sharders if alloction is already requested before.