-
Notifications
You must be signed in to change notification settings - Fork 24
Validator health Transaction Fix #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## staging #982 +/- ##
===========================================
+ Coverage 26.18% 26.19% +0.01%
===========================================
Files 76 76
Lines 7744 7741 -3
===========================================
Hits 2028 2028
+ Misses 5444 5441 -3
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes
The way we were checking if validator has been removed or not was incorrect, we are removing the check and will add it again when Add Blobber and validator, kill and shutdown endpoints is merged .
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):