Skip to content

Fix delete issue caused by LIKE statement #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Fix delete issue caused by LIKE statement #800

merged 3 commits into from
Aug 16, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Aug 15, 2022

Fixes

Fix delete issue caused by sql LIKE statement.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@lpoli lpoli requested a review from cnlangzi August 15, 2022 09:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #800 (0294590) into staging (927e14e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging     #800      +/-   ##
===========================================
- Coverage    24.37%   24.36%   -0.01%     
===========================================
  Files           77       77              
  Lines         7966     7969       +3     
===========================================
  Hits          1942     1942              
- Misses        5754     5757       +3     
  Partials       270      270              
Flag Coverage Δ
Unit-Tests 24.36% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain.net/blobbercore/allocation/deletefilechange.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/reference/object.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lpoli lpoli requested a review from peterlimg August 15, 2022 09:14
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpoli lpoli merged commit e0b595f into staging Aug 16, 2022
@lpoli lpoli deleted the fix/dir-issue branch August 16, 2022 03:51
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants