Fix/challenge timestamp issue #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## staging #784 +/- ##
========================================
Coverage 24.64% 24.64%
========================================
Files 77 77
Lines 7871 7871
========================================
Hits 1940 1940
Misses 5663 5663
Partials 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
ssardana08
suggested changes
Aug 5, 2022
ssardana08
previously requested changes
Aug 5, 2022
3 tasks
peterlimg
suggested changes
Aug 6, 2022
|
|
||
| if err := db.Transaction(func(tx *gorm.DB) error { | ||
| return c.SaveWith(tx) | ||
| }); err != nil { | ||
| logging.Logger.Error("[challenge]add: ", | ||
| zap.String("challenge_id", c.ChallengeID), | ||
| zap.Time("created", c.CreatedAt), | ||
| zap.Time("created", common.ToTime(c.CreatedAt)), |
There was a problem hiding this comment.
We'd better call common.ToTime() one time, and use the result to avoid redundant time conversions.
peterlimg
suggested changes
Aug 7, 2022
| if time.Since(common.ToTime(cr.CreatedAt)) > config.Configuration.ChallengeCompletionTime { | ||
| cr.Status = Cancelled | ||
| cr.StatusMessage = "challenge completion time expired" | ||
| cr.UpdatedAt = time.Now().UTC() |
There was a problem hiding this comment.
We need to call cr.Save() to update the changes to db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR removes ambiguity in CreatedAt field.
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):