Skip to content

fix(worker): removed UpdateBlobberSettings from blobber #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

cnlangzi
Copy link
Contributor

Changes

  • removed UpdateBlobberSettings. Because blobber's settings must be updated by owner wallet. We only have operation wallet on blobber server. it is impossible to update blobber settings. cc @lpoli

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@cnlangzi cnlangzi requested review from peterlimg and dabasov July 30, 2022 23:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #772 (f366a71) into staging (1a95e83) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #772   +/-   ##
========================================
  Coverage    24.41%   24.41%           
========================================
  Files           77       77           
  Lines         7826     7826           
========================================
  Hits          1911     1911           
  Misses        5648     5648           
  Partials       267      267           
Flag Coverage Δ
Unit-Tests 24.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cnlangzi cnlangzi requested a review from peterlimg July 31, 2022 01:06
Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg peterlimg merged commit 14aa587 into staging Aug 1, 2022
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@cnlangzi cnlangzi deleted the fix/remove_update_settings branch January 29, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants