Skip to content

marketing fields fix #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2022
Merged

marketing fields fix #760

merged 3 commits into from
Jul 27, 2022

Conversation

dabasov
Copy link
Contributor

@dabasov dabasov commented Jul 26, 2022

Fixes

Fixed how geolocation and info are set

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

@dabasov dabasov added bug Something isn't working mainnet labels Jul 26, 2022
@dabasov dabasov requested review from cnlangzi and lpoli July 26, 2022 15:57
@dabasov dabasov self-assigned this Jul 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #760 (0c8c7b1) into staging (710e9f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #760   +/-   ##
========================================
  Coverage    23.59%   23.59%           
========================================
  Files           77       77           
  Lines         7980     7980           
========================================
  Hits          1883     1883           
  Misses        5828     5828           
  Partials       269      269           
Flag Coverage Δ
Unit-Tests 23.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 145b0ea into staging Jul 27, 2022
@cnlangzi cnlangzi deleted the fix/marketing-fields branch July 27, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants