Skip to content

Fix challenges #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 23, 2024
Merged

Fix challenges #1486

merged 10 commits into from
Oct 23, 2024

Conversation

Jayashsatolia403
Copy link
Member

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Hitenjain14
Hitenjain14 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Hitenjain14 Hitenjain14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dabasov
dabasov approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit de4f0f5 into sprint-1.18 Oct 23, 2024
4 of 6 checks passed
@dabasov dabasov deleted the fix/verifyTxn branch October 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@Hitenjain14 Hitenjain14 Hitenjain14 approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jayashsatolia403 @dabasov @Hitenjain14