Skip to content

Add file search using names #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 7, 2024
Merged

Add file search using names #1466

merged 16 commits into from
Aug 7, 2024

Conversation

@harsh4723
Copy link
Contributor

@harsh4723 harsh4723 commented Jul 30, 2024 •
edited
Loading

Changes

Add file search using file names, prefix and multi-word queries supported

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

dabasov
dabasov approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov changed the base branch from staging to sprint-1.17 August 7, 2024 17:37
@dabasov dabasov merged commit f3eb60b into sprint-1.17 Aug 7, 2024
@dabasov dabasov deleted the feat/file-search branch August 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterlimg peterlimg Awaiting requested review from peterlimg

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

1 more reviewer

@dabasov dabasov dabasov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harsh4723 @dabasov @Hitenjain14 @Jayashsatolia403