feature: vec3OrthoNormalize does its job without input tangent

0b5vr · Jan 30, 2022 · 6b94628 · 6b94628
1 parent a7872da
commit 6b94628
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/math/vec3/tests/vec3OrthoNormalize.test.ts b/src/math/vec3/tests/vec3OrthoNormalize.test.ts
@@ -3,6 +3,15 @@ import { vec3OrthoNormalize } from '../vec3OrthoNormalize';
 import type { RawVector3 } from '../RawVector3';
 
 describe( 'vec3OrthoNormalize', () => {
+  it( 'returns a orthogonal tangent, without the input tangent', () => {
+    const normal: RawVector3 = [ 0.0, 0.0, 5.0 ];
+    const subject = vec3OrthoNormalize( normal );
+
+    expect( subject.normal ).toBeCloseToArray( [ 0.0, 0.0, 1.0 ] );
+    expect( subject.tangent ).toBeCloseToArray( [ 0.0, 1.0, 0.0 ] );
+    expect( subject.binormal ).toBeCloseToArray( [ -1.0, 0.0, 0.0 ] );
+  } );
+
   it( 'returns a orthogonal tangent', () => {
     const normal: RawVector3 = [ 0.0, 0.0, 5.0 ];
     const tangent: RawVector3 = [ 1.0, 1.0, 1.0 ];

diff --git a/src/math/vec3/vec3OrthoNormalize.ts b/src/math/vec3/vec3OrthoNormalize.ts
@@ -8,7 +8,7 @@ import type { RawVector3 } from './RawVector3';
  */
 export function vec3OrthoNormalize(
   normal: RawVector3,
-  tangent: RawVector3,
+  tangent: RawVector3 = [ 0.0, 1.0, 0.0 ],
   binormal?: RawVector3,
 ): {
     normal: RawVector3,