Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pydantic v2 with v1 backport #326

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

jaykv
Copy link
Contributor

@jaykv jaykv commented Jul 18, 2023

This is a less involved update to support pydantic v2. Compared to #324, this keeps the internals the same and uses the pydantic.v1 backport for imports from v2.

@jaykv jaykv changed the title Support Pydantic v2 Support Pydantic v2 with v1 backport Jul 18, 2023
Makefile Show resolved Hide resolved
kemingy
kemingy previously approved these changes Jul 18, 2023
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉

Makefile Show resolved Hide resolved
@kemingy kemingy added this pull request to the merge queue Jul 18, 2023
Merged via the queue into 0b01001001:master with commit 5c27305 Jul 18, 2023
7 checks passed
@kemingy
Copy link
Member

kemingy commented Jul 18, 2023

Emmm, it seems the GitHub merge queue is not mature. I thought it would remove it from the queue if any changes occurred. Sorry for the inconvenience.

@jaykv
Copy link
Contributor Author

jaykv commented Jul 18, 2023

Emmm, it seems the GitHub merge queue is not mature. I thought it would remove it from the queue if any changes occurred. Sorry for the inconvenience.

All good! want me to make another PR for that Makefile change?

@kemingy
Copy link
Member

kemingy commented Jul 18, 2023

All good! want me to make another PR for that Makefile change?

Let me fix this and create a new release. Thanks!

@jaykv jaykv deleted the quick-migrate-pydanticv2 branch July 18, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants