Add validation when passing ParsingConfig in args#926
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to ensure that a ParsingConfig is not passed as an argument in the wrong position by throwing an appropriate ArgumentException. It updates tests to verify the error message, adds a new Args check in Check.cs, and updates DynamicQueryableExtensions to consistently call Check.Args.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/System.Linq.Dynamic.Core.Tests/QueryableTests.Where.cs | Adds a test verifying the new ParsingConfig validation error message. |
| test/System.Linq.Dynamic.Core.Tests/ExpressionTests.cs | Updates method call order to pass config as the first parameter. |
| src/System.Linq.Dynamic.Core/Validation/Check.cs | Introduces Check.Args for validating argument order regarding ParsingConfig. |
| src/System.Linq.Dynamic.Core/DynamicQueryableExtensions.cs | Inserts Check.Args validations in various query extension methods to enforce the new argument order. |
Comments suppressed due to low confidence (1)
src/System.Linq.Dynamic.Core/DynamicQueryableExtensions.cs:688
- [nitpick] Review the removal of explicit parameter name arguments in Check.NotEmpty calls to ensure that CallerArgumentExpression yields the expected parameter names in all contexts.
Check.NotEmpty(keySelector);
This was referenced Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.