Skip to content

Conversation

@spudwebb
Copy link

The properties added are used by the Configuration command class values.

@spudwebb
Copy link
Author

@marcus-j-davies I added a commit that adds a ValueFormat parameter to ZWJSS_SetRawConfigParameterValue method, because ZWaveJS complain that if you specify valueSize you need to specify valueFormat as well

@marcus-j-davies
Copy link
Member

marcus-j-davies commented Dec 18, 2023

Thanks @spudwebb - I marked this as a FIX ME for that reason,I'll get it merged this evening.

@marcus-j-davies
Copy link
Member

marcus-j-davies commented Dec 18, 2023

@spudwebb
Copy link
Author

I agree, I can do it tomorrow.

@marcus-j-davies
Copy link
Member

I'm here, so will do it shortly, and merge 👍

@marcus-j-davies
Copy link
Member

marcus-j-davies commented Dec 18, 2023

@spudwebb

I have added all overloads according to the Options object variants - and switched to using the defined enums
https://github.com/zwave-js/node-zwave-js/blob/9549a040477364b54a2df617a42fd30639e67e14/packages/cc/src/cc/ConfigurationCC.ts#L107

// Variant 1: Normal parameter, defined in a config file
public Task<CMDResult> ZWJSS_SetRawConfigParameterValue(int Parameter, int Value)


// Variant 2: Normal parameter, not defined in a config file
public Task<CMDResult> ZWJSS_SetRawConfigParameterValue(int Parameter, int Value, int ValueSize, Enums.ConfigValueFormat ValueFormat)

//Variant 3: Partial parameter, must be defined in a config file
public Task<CMDResult> ZWJSS_SetRawConfigParameterValue(int Parameter, int Bitmask, int Value)

@marcus-j-davies marcus-j-davies merged commit 533d7cc into zwave-js:4.0.0 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants