Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue for Rake task CI users: explicit version on did_you_mean dependency #21

Closed
olleolleolle opened this issue Sep 7, 2017 · 9 comments

Comments

@olleolleolle
Copy link
Contributor

Situation: As a CI user of the Rake task, I can have gem activation issues due to explicit version demands. Example: cucumber/aruba#492 (comment)

Resolution for that project: stop using it in CI. cucumber/aruba#493

(This is a vague description of the issue, but I wanted it saved, here, so that we can deal with it together.)

@zverok
Copy link
Owner

zverok commented Sep 7, 2017

Oh damn. I've already had a fight with the bundled gem on CI, but probably solved the problem in a wrong way :(
On it.

@zverok
Copy link
Owner

zverok commented Sep 7, 2017

Seems that simplified version of setting up the dependency did the trick: https://travis-ci.org/zverok/yard-junk

Do we have any way of test it against aruba's Travis?..

BTW, I've also noticed aruba supports Rubies since 1.9.3. Till today, yard-junk supported only Ruby >= 2.3.0, but I added 2.1 and 2.2 in master.

Not sure about 2.0 and 1.9.3 -- it is possible to support them, probably... But I don't really want to :)

@zverok
Copy link
Owner

zverok commented Sep 7, 2017

(Though, in fact, it doesn't look as a really important task to support all Ruby versions, as docs could be checked only on one of them.)

@olleolleolle
Copy link
Contributor Author

docs could be checked only on one

This is a good point. This could be the way forward that we teach.

It could be worth exampling this with a Travis CI config snippet which uses a matrix line which uses rvm: 2.4.1 and does a script: bundle exec rake yard:junk

@zverok
Copy link
Owner

zverok commented Sep 7, 2017

So, my CI is green now...
Wanna me to release new gem version?

@olleolleolle
Copy link
Contributor Author

@zverok Would be great!

@zverok
Copy link
Owner

zverok commented Sep 7, 2017

Done!

@olleolleolle
Copy link
Contributor Author

I will close this as fixed and open another issue if it appears.

@zverok
Copy link
Owner

zverok commented Sep 11, 2017

Hey. Just notifying: I've did the SECOND fix of the problem, now hopefully the right way. Released with 0.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants