correct change tasks validation (ydb-platform#13064)

Author: ivanmorozov333

ydb/core/tx/columnshard/columnshard.cpp

@@ -67,7 +67,6 @@ void TColumnShard::TrySwitchToWork(const TActorContext& ctx) {
         AFL_INFO(NKikimrServices::TX_COLUMNSHARD)("event", "skip_switch_to_work")("reason", "db_reading_not_finished");
         return;
     }
-
     ProgressTxController->OnTabletInit();
     {
         const TLogContextGuard gLogging =

ydb/core/tx/columnshard/columnshard_impl.cpp

@@ -94,6 +94,7 @@ TColumnShard::TColumnShard(TTabletStorageInfo* info, const TActorId& tablet)
     , BackgroundController(Counters.GetBackgroundControllerCounters())
     , NormalizerController(StoragesManager, Counters.GetSubscribeCounters())
     , SysLocks(this) {
+    AFL_VERIFY(TabletActivityImpl->Inc() == 1);
 }
 
 void TColumnShard::OnDetach(const TActorContext& ctx) {
@@ -895,6 +896,7 @@ void TColumnShard::StartCompaction(const std::shared_ptr<NPrioritiesQueue::TAllo
     }
 
     auto compaction = dynamic_pointer_cast<NOlap::NCompaction::TGeneralCompactColumnEngineChanges>(indexChanges);
+    compaction->SetActivityFlag(GetTabletActivity());
     compaction->SetQueueGuard(guard);
     compaction->Start(*this);
 
@@ -1148,11 +1150,12 @@ void TColumnShard::SetupCleanupInsertTable() {
 }
 
 void TColumnShard::Die(const TActorContext& ctx) {
+    AFL_VERIFY(TabletActivityImpl->Dec() == 0);
     CleanupActors(ctx);
     NTabletPipe::CloseAndForgetClient(SelfId(), StatsReportPipe);
     UnregisterMediatorTimeCast();
     NYDBTest::TControllers::GetColumnShardController()->OnTabletStopped(*this);
-    return IActor::Die(ctx);
+    IActor::Die(ctx);
 }
 
 void TColumnShard::Handle(NActors::TEvents::TEvUndelivered::TPtr& ev, const TActorContext&) {

ydb/core/tx/columnshard/columnshard_impl.h

@@ -326,6 +326,8 @@ class TColumnShard: public TActor<TColumnShard>, public NTabletFlatExecutor::TTa
     void ActivateTiering(const ui64 pathId, const THashSet<TString>& usedTiers);
     void OnTieringModified(const std::optional<ui64> pathId = {});
 
+    std::shared_ptr<TAtomicCounter> TabletActivityImpl = std::make_shared<TAtomicCounter>(0);
+
 public:
     ui64 BuildEphemeralTxId() {
         static TAtomicCounter Counter = 0;
@@ -602,6 +604,10 @@ class TColumnShard: public TActor<TColumnShard>, public NTabletFlatExecutor::TTa
 public:
     ui64 TabletTxCounter = 0;
 
+    std::shared_ptr<const TAtomicCounter> GetTabletActivity() const {
+        return TabletActivityImpl;
+    }
+
     const TTablesManager& GetTablesManager() const {
         return TablesManager;
     }

ydb/core/tx/columnshard/engines/changes/abstract/abstract.h

@@ -214,6 +214,7 @@ class TColumnEngineChanges {
     std::shared_ptr<NDataLocks::TManager::TGuard> LockGuard;
     TString AbortedReason;
     const TString TaskIdentifier = TGUID::CreateTimebased().AsGuidString();
+    std::shared_ptr<const TAtomicCounter> ActivityFlag;
 
 protected:
     std::optional<TDataAccessorsResult> FetchedDataAccessors;
@@ -246,6 +247,15 @@ class TColumnEngineChanges {
     virtual void OnDataAccessorsInitialized(const TDataAccessorsInitializationContext& context) = 0;
 
 public:
+    bool IsActive() const {
+        return !ActivityFlag || ActivityFlag->Val();
+    }
+
+    void SetActivityFlag(const std::shared_ptr<const TAtomicCounter>& flag) {
+        AFL_VERIFY(!ActivityFlag);
+        ActivityFlag = flag;
+    }
+
     std::shared_ptr<TDataAccessorsRequest> ExtractDataAccessorsRequest() const {
         AFL_VERIFY(!!PortionsToAccess);
         return std::move(PortionsToAccess);

ydb/core/tx/columnshard/engines/changes/compaction.cpp

@@ -71,7 +71,7 @@ TCompactColumnEngineChanges::TCompactColumnEngineChanges(
 }
 
 TCompactColumnEngineChanges::~TCompactColumnEngineChanges() {
-    Y_DEBUG_ABORT_UNLESS(!NActors::TlsActivationContext || !NeedGranuleStatusProvide);
+    Y_DEBUG_ABORT_UNLESS(!NActors::TlsActivationContext || !NeedGranuleStatusProvide || !IsActive());
 }
 
 }   // namespace NKikimr::NOlap