Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: Add footer notification for messages. #824

Closed
wants to merge 2 commits into from
Closed

model: Add footer notification for messages. #824

wants to merge 2 commits into from

Commits on Feb 17, 2021

  1. helper/model: Add footer notification for message sent outside narrow. 

    This commit generalizes the code for footer notification when a message
is sent/edited outside current narrow. This will give the user a pointer
as to why the message disappeared from the screen. The code is hooked to
the part where message request is sent to the server, hence preventing the
extra check for user_id being same as message_sender_id.

Tests amended.
Fixes zulip#781.
    @zee-bit
    zee-bit committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    1d2152d View commit details
    Browse the repository at this point in the history

  2. refactor: Type annotate request to Composition TypedDict. 

    This commit refactors the request dict's type to one of Composition
class. Previously, the type of request was Dict[str, Any] which was
flexible when it comes type-checking. This change narrows the scope
of type-checking, since the Composition class uses TypedDict.
    @zee-bit
    zee-bit committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    3624c33 View commit details
    Browse the repository at this point in the history