Shrink space to left of message by using unicode to mark edited messages. #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetmishra
reviewed
May 11, 2020
There was a problem hiding this comment.
@neiljp This does help in shrinking the space and allowing more screen real estate for messages. 👍
Another alternative worth considering could be \N{WRITING HAND}.
By moving from 'EDITED' to '✎……' we avoid having a distracting label to the left of the message, and can shrink the space reserved for it to give more space for the message text. This commit reduces the space to the left by 3. Based on a suggestion by Tim Abbott.
neiljp
force-pushed
the
2020-05-11-EDITED-to-unicode-icons
branch
from
cc4c823
to
cb1778d
Compare
|
This is the new style: |
neiljp
added
feedback wanted
further discussion required
|
This was discussed in #zulip-terminal>EDITED marking #T655 on chat.zulip.org |
|
Heads up @neiljp, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving from 'EDITED' to '✎……' we avoid having a distracting label to
the left of the message, and can shrink wasted space to the left of the
message.
This commit reduces the space to the left by 3.
Based on a suggestion by Tim Abbott.