[WIP] - Mute topics from within ZT #467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles updating muting/unmuting topics in a stream by sending the request through the server through an API class.
We make use of the PopUpConfirmation for confirming muting/unmuting topics, using TopicButtons stream_id and topic names, displaying the affected stream name and topic name of muting/unmuting being performed.
We want to be notified about changes in subscriptions like muting/unmuting of topics in a stream, hence we register the event_type 'muted_topics' to the event queue on startup, with a handler method which responds to these events appropriately. We store mappings between topic_name and topic_buttons so tha retrieval of buttons is easier when a change in topic muting event occurs.
During muting of a topic: * We decrease All_msg count by the correct amount * If there are unread messages in the stream, we decrease its count by the same amount as well. During unmuting of a topic: * If there are unread messages in the stream, we replace 'M' with the correct unread count. * If there are no unread messages, we remove the marked 'M'
New section 'Topic list actions' created in README. New 'topic_list' category created in keys for mapping keys belonging to topic list actions.
On pressing TOGGLE_MUTE_TOPIC, we now ask for confirmation before performing the action of muting/unmuting topics.
|
Heads up @sumanthvrao, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
5 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to mute topics from within ZT on
Mkeypress:with the model function passed in as callback.